Ngone51 commented on a change in pull request #25943:
[WIP][SPARK-29261][SQL][CORE] Support recover live entities from KVStore for
(SQL)AppStatusListener
URL: https://github.com/apache/spark/pull/25943#discussion_r333634637
##########
File path: core/src/main/scala/org/apache/spark/status/storeTypes.scala
##########
@@ -76,6 +109,29 @@ private[spark] class JobDataWrapper(
@JsonIgnore @KVIndex("completionTime")
private def completionTime: Long =
info.completionTime.map(_.getTime).getOrElse(-1L)
+
+ def toLiveJob: LiveJob = {
Review comment:
While converting `LiveJob` to `JobDataWrapper`, only
`completedIndices.size`/`completedStages.size` are written into KVStore. So,
it's impossible to recover the detail `completedIndices`/`completedStages`. So,
as a compromises, we only recover the number in this case.
And this brings a problem that the recovered live job wouldn't be 100% the
same as the previous one. But, this can be acceptable when you look at
their(`completedIndices`, `completedStages`) usages in `AppStatusListener`, as
it does not mistake the final result(that is number).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
