advancedxy commented on a change in pull request #26085: [SPARK-29434] [Core]
Improve the MapStatuses Serialization Performance
URL: https://github.com/apache/spark/pull/26085#discussion_r333809807
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -822,18 +827,43 @@ private[spark] object MapOutputTracker extends Logging {
} {
objOut.close()
}
- val arr = out.toByteArray
+
+ val arr: Array[Byte] = {
+ val compressedOut = new ByteArrayOutputStream(4096)
+ val zos = new ZstdOutputStream(compressedOut)
+ Utils.tryWithSafeFinally {
+ compressedOut.write(DIRECT)
+ zos.write(out.getBuf, 0, out.size())
Review comment:
I think we can replace this call with `out.writeTo(zos)`? So that we can
avoid exposing the `buf` directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
