HeartSaVioR commented on a change in pull request #25670: [SPARK-28869][CORE]
Roll over event log files
URL: https://github.com/apache/spark/pull/25670#discussion_r334658321
##########
File path: core/src/main/scala/org/apache/spark/internal/config/package.scala
##########
@@ -179,6 +179,19 @@ package object config {
private[spark] val EVENT_LOG_CALLSITE_LONG_FORM =
ConfigBuilder("spark.eventLog.longForm.enabled").booleanConf.createWithDefault(false)
+ private[spark] val EVENT_LOG_ENABLE_ROLLING =
+ ConfigBuilder("spark.eventLog.logRolling.enabled")
+ .doc("Whether rolling over event log files is enabled. If set to true,
it cuts down " +
+ "each event log file to the configured size.")
+ .booleanConf
+ .createWithDefault(false)
+
+ private[spark] val EVENT_LOG_ROLLED_EVENT_LOG_MAX_FILE_SIZE =
Review comment:
I'll apply former first, as we may need to hear the another voice for
changing config name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
