cloud-fan commented on a change in pull request #26112: [SPARK-29364][SQL]
Return an interval from date subtract according to SQL standard
URL: https://github.com/apache/spark/pull/26112#discussion_r334904771
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -849,12 +850,18 @@ object TypeCoercion {
case Add(l @ DateType(), r @ IntegerType()) => DateAdd(l, r)
case Add(l @ IntegerType(), r @ DateType()) => DateAdd(r, l)
case Subtract(l @ DateType(), r @ IntegerType()) => DateSub(l, r)
- case Subtract(l @ DateType(), r @ DateType()) => DateDiff(l, r)
- case Subtract(l @ TimestampType(), r @ TimestampType()) =>
TimestampDiff(l, r)
+ case Subtract(l @ DateType(), r @ DateType()) =>
+ if (SQLConf.get.getConf(SQLConf.LEGACY_DATES_SUBTRACTION)) {
Review comment:
We want to switch to the new behavior by default, with a legacy config to
restore the old behavior. This is different from other ANSI behaviors, which we
don't want to switch to by default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
