Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4299#discussion_r23958649
  
    --- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
    @@ -282,7 +282,9 @@ private[spark] object Utils extends Logging {
             if (dir.exists() || !dir.mkdirs()) {
               dir = null
             } else {
    -          if (!chmod700(dir)) {
    +          // Restrict file permissions via chmod if available.
    +          // For Windows this step is ignored.
    +          if (!isWindows && !chmod700(dir)) {
    --- End diff --
    
    Actually, the current ordering seems more intuitive, so I'm going to keep 
the patch in its current form.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to