AngersZhuuuu commented on a change in pull request #26053:
[SPARK-29379][SQL]SHOW FUNCTIONS show '!=', '<>' , 'between', 'case'
URL: https://github.com/apache/spark/pull/26053#discussion_r335822035
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
##########
@@ -2064,7 +2064,7 @@ abstract class DDLSuite extends QueryTest with
SQLTestUtils {
test("show functions") {
withUserDefinedFunction("add_one" -> true) {
- val numFunctions = FunctionRegistry.functionSet.size.toLong
+ val numFunctions = FunctionRegistry.functionSet.size.toLong + 4L
Review comment:
> ah missed this one. We should use
`FunctionsCommand.virtualOperators.length` to be future-proof.
Good ideal, make it more clear. Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
