Github user mengxr commented on the pull request: https://github.com/apache/spark/pull/3062#issuecomment-72567721 @srowen Yes, the implementation would live under the `mllib.pmml` package and we add `toPMML` to models that we support. For the return type, exposing third-party APIs is not recommended in Spark. We used Guava's Optional, which turned out to be a bad choice for maintenance. There are pros/cons for other types. 1. String. Easy to save/load, but it may not be able to handle super large XML. 2. `Result` from `javax.xml`. Officially supported by Java, but most users don't know how to use it. So it really depends on how big the model is and whether it is necessary to output XML as a stream.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org