Github user freeman-lab commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3803#discussion_r23980541
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
    @@ -361,6 +363,25 @@ class StreamingContext private[streaming] (
     
       /**
        * Create a input stream that monitors a Hadoop-compatible filesystem
    +   * for new files and reads them using the given key-value types and 
input format.
    +   * Files must be written to the monitored directory by "moving" them 
from another
    +   * location within the same file system. File names starting with . are 
ignored.
    +   * @param directory HDFS directory to monitor for new file
    +   * @param conf Hadoop configuration
    +   * @tparam K Key type for reading HDFS file
    +   * @tparam V Value type for reading HDFS file
    +   * @tparam F Input format for reading HDFS file
    +   */
    +  def fileStream[
    --- End diff --
    
    Fine with me, though would require wiring the extra arguments (`filter` and 
`newFilesOnly`) through to all the binary record methods (because they'll also 
need the `conf`). Should we expose those arguments in `binaryRecords`? Or just 
use their defaults?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to