Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/4308#discussion_r23988104
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
---
@@ -175,7 +175,10 @@ case class EqualTo(left: Expression, right:
Expression) extends BinaryComparison
null
} else {
val r = right.eval(input)
- if (r == null) null else l == r
+ if (r == null) null
+ else if (left.dataType != BinaryType) l == r
+ else BinaryType.ordering.compare(
+ l.asInstanceOf[Array[Byte]], r.asInstanceOf[Array[Byte]]) == 0
--- End diff --
Filed SPARK-5553 to track this. I'd like to make sure equality comparison
for binary types works properly in this PR. Also, we're already using
`Ordering` to compare binary values in `LessThan` and `GreaterThan` etc., so at
least this isn't a regression.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
