beliefer commented on a change in pull request #25001: [SPARK-28083][SQL] Support LIKE ... ESCAPE syntax URL: https://github.com/apache/spark/pull/25001#discussion_r338423500
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala ########## @@ -149,10 +153,17 @@ case class Like(left: Expression, right: Expression) extends StringRegexExpressi } else { val pattern = ctx.freshName("pattern") val rightStr = ctx.freshName("rightStr") + val escapeChar = escapeCharOpt.map { str => + if (str.equals("\"") || str.equals("\\")) { Review comment: @HyukjinKwon @maropu I added the comments for explain the double escape. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org