zhengruifeng commented on a change in pull request #26247: [SPARK-29566][ML]
Imputer should support single-column input/output
URL: https://github.com/apache/spark/pull/26247#discussion_r338885161
##########
File path: python/pyspark/ml/feature.py
##########
@@ -1270,11 +1319,11 @@ class Imputer(JavaEstimator, _ImputerParams,
JavaMLReadable, JavaMLWritable):
"""
@keyword_only
- def __init__(self, strategy="mean", missingValue=float("nan"),
inputCols=None,
- outputCols=None):
+ def __init__(self, strategy="mean", missingValue=float("nan"),
inputCol=None, inputCols=None,
Review comment:
Here we must place newly added params `inputCol` & `outputCol` behind
existing ones
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
