kiszk commented on a change in pull request #25728: [SPARK-29020][WIP][SQL]
Improving array_sort behaviour
URL: https://github.com/apache/spark/pull/25728#discussion_r338927347
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CollectionExpressionsSuite.scala
##########
@@ -363,16 +363,6 @@ class CollectionExpressionsSuite extends SparkFunSuite
with ExpressionEvalHelper
val arrayArrayStruct = Literal.create(Seq(aas2, aas1), typeAAS)
checkEvaluation(new SortArray(arrayArrayStruct), Seq(aas1, aas2))
-
- checkEvaluation(ArraySort(a0), Seq(1, 2, 3))
- checkEvaluation(ArraySort(a1), Seq[Integer]())
- checkEvaluation(ArraySort(a2), Seq("a", "b"))
- checkEvaluation(ArraySort(a3), Seq("a", "b", null))
- checkEvaluation(ArraySort(a4), Seq(d1, d2))
- checkEvaluation(ArraySort(a5), Seq(null, null))
- checkEvaluation(ArraySort(arrayStruct), Seq(create_row(1), create_row(2)))
- checkEvaluation(ArraySort(arrayArray), Seq(aa1, aa2))
- checkEvaluation(ArraySort(arrayArrayStruct), Seq(aas1, aas2))
Review comment:
We still miss the original tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
