cloud-fan commented on a change in pull request #26177: [SPARK-29520][SS] Fix
checks of negative intervals
URL: https://github.com/apache/spark/pull/26177#discussion_r339439208
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -119,4 +121,32 @@ object IntervalUtils {
case _: IllegalArgumentException => null
}
}
+
+ /**
+ * Gets interval duration
+ *
+ * @param cal - the interval to get duration
+ * @param targetUnit - time units of the result
+ * @param daysPerMonth - the number of days per one month
+ * @return duration in the specified time units
+ */
+ def getDuration(
+ cal: CalendarInterval,
+ targetUnit: TimeUnit,
+ daysPerMonth: Int = 31): Long = {
Review comment:
Then we can remove the default value? The caller side should explicitly
specify that it wants 31 days per month and why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
