MaxGekk commented on a change in pull request #26134: [SPARK-29486][SQL]
CalendarInterval should have 3 fields: months, days and microseconds
URL: https://github.com/apache/spark/pull/26134#discussion_r339444674
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -61,7 +61,7 @@ object IntervalUtils {
}
def getDays(interval: CalendarInterval): Long = {
Review comment:
The method was added for feature parity with PostgreSQL which tracks days in
a separate variable too, and doesn't perform normalization:
```sql
maxim=# select INTERVAL '1 day 48 hour';
interval
----------------
1 day 48:00:00
(1 row)
```
> Which one is corrected?
I think we could change current behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
