MaxGekk commented on a change in pull request #26261: [SPARK-29607][SQL] Move static methods from CalendarInterval to IntervalUtils URL: https://github.com/apache/spark/pull/26261#discussion_r339452615
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala ########## @@ -119,4 +121,202 @@ object IntervalUtils { case _: IllegalArgumentException => null } } + + private val yearMonthPattern = Pattern.compile("^([+|-])?(\\d+)-(\\d+)$") Review comment: To use Scala regexp, I will have to restructure the code significantly, so, it will be impossible to track anything. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org