cloud-fan commented on a change in pull request #26261: [SPARK-29607][SQL] Move
static methods from CalendarInterval to IntervalUtils
URL: https://github.com/apache/spark/pull/26261#discussion_r339673082
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/IntervalUtils.scala
##########
@@ -119,4 +123,195 @@ object IntervalUtils {
case _: IllegalArgumentException => null
}
}
+
+ private def toLongWithRange(
+ fieldName: String,
+ s: String,
+ minValue: Long,
+ maxValue: Long): Long = {
+ val result = if (s == null) 0L else s.toLong
+ require(minValue <= result && result <= maxValue,
+ s"$fieldName $result outside range [$minValue, $maxValue]")
+
+ result
+ }
+
+ private val yearMonthPattern = "^\\s*([+|-])?(\\d+)-(\\d+)\\s*$".r
Review comment:
The previous regex does not have the `\\s*` at the beginning and end. This
is because we get the string from parser which already trims the white spaces.
Shall we change it back?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
