beliefer commented on a change in pull request #26282: [SPARK-29619] Add
meaningful log and retry for start python worker process
URL: https://github.com/apache/spark/pull/26282#discussion_r339884891
##########
File path:
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala
##########
@@ -206,15 +206,28 @@ private[spark] class PythonWorkerFactory(pythonExec:
String, envVars: Map[String
workerEnv.put("PYTHON_WORKER_FACTORY_SECRET", authHelper.secret)
// This is equivalent to setting the -u flag; we use it because
ipython doesn't support -u:
workerEnv.put("PYTHONUNBUFFERED", "YES")
- daemon = pb.start()
-
- val in = new DataInputStream(daemon.getInputStream)
- try {
- daemonPort = in.readInt()
- } catch {
- case _: EOFException =>
- throw new SparkException(s"No port number in $daemonModule's
stdout")
Review comment:
I'm Sorry! I only know the daemon sometimes dead and exit with code 139.
We use Yarn mode, so the hierarchical relationship looks like:
Yarn container process
|
| ----JVM process
|
| ----- python process
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
