shahidki31 commented on a change in pull request #26241: [SPARK-29585][WEBUI] Fix stagePage duration URL: https://github.com/apache/spark/pull/26241#discussion_r339902038
########## File path: core/src/main/scala/org/apache/spark/ui/jobs/StageTable.scala ########## @@ -417,19 +417,8 @@ private[ui] class StageDataSource( case Some(t) => UIUtils.formatDate(t) case None => "Unknown" } - val finishTime = stageData.completionTime.map(_.getTime()).getOrElse(currentTime) - - // The submission time for a stage is misleading because it counts the time - // the stage waits to be launched. (SPARK-10930) - val duration = stageData.firstTaskLaunchedTime.map { date => - val time = date.getTime() - if (finishTime > time) { - finishTime - time - } else { - None - currentTime - time - } - } + + val duration = Some(stageData.executorRunTime) Review comment: Thanks @teeyog. I think this was the behavior in the previous versions of spark. I am not sure we need to change it. What ever you are proposing is `duration = executorRunTime + ser/deser time + gettingResultTime`. But, Already these 3 columns are getting disaplyed in the task table right? If we unify all would we need to display individual columns? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org