turboFei edited a comment on issue #26086: [SPARK-29302] Make the file name of a task for dynamic partition overwrite be unique URL: https://github.com/apache/spark/pull/26086#issuecomment-547277051 > Is this different to #24142? @viirya Thanks for your reply. There is a little different. I have read the comments of #24142 and it seems there is a risk that for non-FileOutputCommitter, if a task failed and failed to cleanup task output, spark would give duplicate result. In this PR, I only named a task file with taskId and attemptId for dynamic partition overwrite, for that dynamicPartitionOverwrite would keep a filesToMove, so there is no risk to cause duplicate result. PS: I think it is rarely to meet non-FileOutputCommitter case.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
