cloud-fan commented on a change in pull request #26289: [SPARK-28560][SQL][followup] support the build side to local shuffle reader as far as possible in BroadcastHashJoin URL: https://github.com/apache/spark/pull/26289#discussion_r340460618
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ########## @@ -215,9 +267,32 @@ class AdaptiveQueryExecSuite assert(smj.size == 3) val bhj = findTopLevelBroadcastHashJoin(adaptivePlan) assert(bhj.size == 3) - // The child of remaining two BroadcastHashJoin is not ShuffleQueryStage. - // So only two LocalShuffleReader. - checkNumLocalShuffleReaders(adaptivePlan, 1) + // *(6) BroadcastHashJoin [cast(value#14 as int)], [a#220], Inner, BuildLeft Review comment: ditto ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org