Github user freeman-lab commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3803#discussion_r24064747
  
    --- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
    @@ -671,7 +674,11 @@ class SparkContext(config: SparkConf) extends Logging 
with ExecutorAllocationCli
           classOf[LongWritable],
           classOf[BytesWritable],
           conf=conf)
    -    val data = br.map{ case (k, v) => v.getBytes}
    +    val data = br.map { case (k, v) =>
    +      val bytes = v.getBytes
    +      assert(bytes.length == recordLength, "Byte array does not have 
correct length")
    +      bytes
    --- End diff --
    
    Gotcha, I think it's ok as is then. Given what `FixedLengthInputFormat` is 
doing, this is more a defensive assertion, it's not something the user should 
hit due to an inappropriate input.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to