maropu commented on a change in pull request #26366: [SPARK-29722][SQL] Non
reversed keywords should be able to be used in high order functions
URL: https://github.com/apache/spark/pull/26366#discussion_r341834196
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -718,8 +718,8 @@ primaryExpression
| '(' query ')'
#subqueryExpression
| qualifiedName '(' (setQuantifier? argument+=expression (','
argument+=expression)*)? ')'
(OVER windowSpec)?
#functionCall
- | IDENTIFIER '->' expression
#lambda
- | '(' IDENTIFIER (',' IDENTIFIER)+ ')' '->' expression
#lambda
+ | identifier '->' expression
#lambda
+ | '(' identifier (',' identifier)+ ')' '->' expression
#lambda
Review comment:
Ur, I see. Looks reasonable to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
