maropu commented on a change in pull request #26365: [SPARK-29720][CORE] Add linux condition to make ProcfsMetricsGetter more complete URL: https://github.com/apache/spark/pull/26365#discussion_r341834561
########## File path: core/src/main/scala/org/apache/spark/executor/ProcfsMetricsGetter.scala ########## @@ -26,6 +26,8 @@ import scala.collection.mutable import scala.collection.mutable.ArrayBuffer import scala.util.Try +import org.apache.hadoop.util.Shell Review comment: How about checking `os.name` instead of using hadoop-commons? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
