maropu commented on a change in pull request #26107: [SPARK-28885][SQL] Follow
ANSI store assignment rules in table insertion by default
URL: https://github.com/apache/spark/pull/26107#discussion_r341835437
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/SQLQueryTestSuite.scala
##########
@@ -143,7 +143,19 @@ class SQLQueryTestSuite extends QueryTest with
SharedSparkSession {
/** List of test cases to ignore, in lower cases. */
protected def blackList: Set[String] = Set(
- "blacklist.sql" // Do NOT remove this one. It is here to test the
blacklist functionality.
+ "blacklist.sql", // Do NOT remove this one. It is here to test the
blacklist functionality.
+ // SPARK-28885 String value is not allowed to be stored as numeric type
with
+ // ANSI store assignment policy.
+ "postgreSQL/numeric.sql",
+ "postgreSQL/int2.sql",
+ "postgreSQL/int4.sql",
+ "postgreSQL/int8.sql",
+ "postgreSQL/float4.sql",
+ "postgreSQL/float8.sql",
+ // SPARK-28885 String value is not allowed to be stored as date/timestamp
type with
+ // ANSI store assignment policy.
+ "postgreSQL/date.sql",
Review comment:
> I am not sure about whether there is a guideline in porting the PgSQL test
files. Such modifications are allowed, right?
Yea, I think that's ok. cc: @wangyum @dongjoon-hyun @HyukjinKwon
If you have no time to do, I'll check next week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
