yaooqinn commented on a change in pull request #26371: [SPARK-27976][SQL] Add built-in Array Functions: array_append URL: https://github.com/apache/spark/pull/26371#discussion_r341893016
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala ########## @@ -3928,3 +3928,128 @@ case class ArrayExcept(left: Expression, right: Expression) extends ArrayBinaryL override def prettyName: String = "array_except" } + +@ExpressionDescription( + usage = """ + _FUNC_(array, element) - Returns an array of appending an element to the end of an array + """, + examples = """ + Examples: + > SELECT _FUNC_(array(1, 2, 3), 3); + [1,2,3,3] + > SELECT _FUNC_(array(1, 2, 3), null); + [1,2,3,null] + > SELECT _FUNC_(a, e) FROM VALUES (array(1,2), 3), (array(3, 4), null), (null, 3) tbl(a, e); + NULL + [1,2,3] + [3,4,null] + """, + since = "3.0.0") +case class ArrayAppend(left: Expression, right: Expression) extends BinaryExpression { Review comment: I just have a quick research on the master branch which I build on 2019-10-29, ```sql spark-sql> select concat(array(null), null); Error in query: cannot resolve 'concat(array(NULL), CAST(NULL AS STRING))' due to data type mismatch: input to function concat should all be the same type, but it's [array<null>, string]; line 1 pos 7; 'Project [unresolvedalias(concat(array(null), cast(null as string)), None)] +- OneRowRelation spark-sql> select concat(array(1, 2), null); Error in query: cannot resolve 'concat(array(1, 2), CAST(NULL AS STRING))' due to data type mismatch: input to function concat should all be the same type, but it's [array<int>, string]; line 1 pos 7; 'Project [unresolvedalias(concat(array(1, 2), cast(null as string)), None)] +- OneRowRelation spark-sql> select concat(array(1, 2), array(null)); [1,2,null] Time taken: 2.908 seconds, Fetched 1 row(s) ``` Also, currently I don't know how to change `select array_append(null, 3);` this to concat ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org