cloud-fan commented on a change in pull request #26337: [SPARK-29679][SQL] Make
interval type comparable and orderable
URL: https://github.com/apache/spark/pull/26337#discussion_r344189789
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
##########
@@ -855,6 +855,11 @@ object TypeCoercion {
case Divide(l @ CalendarIntervalType(), r @ NumericType()) =>
DivideInterval(l, r)
+ case b @ BinaryOperator(l @ CalendarIntervalType(), r @ NullType()) =>
Review comment:
This is a little hacky. Maybe we should introduce `UnresolvedMultiply` and
`UnresolvedDivide`, so that we don't need to hack the type coercion rules.
We can try it in followup.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
