dilipbiswal commented on a change in pull request #26437: [SPARK-29800][SQL]
Plan Exists 's subquery in PlanSubqueries
URL: https://github.com/apache/spark/pull/26437#discussion_r344582313
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
##########
@@ -106,12 +106,20 @@ object RewritePredicateSubquery extends
Rule[LogicalPlan] with PredicateHelper {
// Filter the plan by applying left semi and left anti joins.
withSubquery.foldLeft(newFilter) {
- case (p, Exists(sub, conditions, _)) =>
- val (joinCond, outerPlan) = rewriteExistentialExpr(conditions, p)
- buildJoin(outerPlan, sub, LeftSemi, joinCond)
- case (p, Not(Exists(sub, conditions, _))) =>
- val (joinCond, outerPlan) = rewriteExistentialExpr(conditions, p)
- buildJoin(outerPlan, sub, LeftAnti, joinCond)
+ case (p, exists @ Exists(sub, conditions, _)) =>
+ if (SubqueryExpression.hasCorrelatedSubquery(exists)) {
+ val (joinCond, outerPlan) = rewriteExistentialExpr(conditions, p)
+ buildJoin(outerPlan, sub, LeftSemi, joinCond)
+ } else {
+ Filter(exists, newFilter)
+ }
+ case (p, Not(exists @ Exists(sub, conditions, _))) =>
+ if (SubqueryExpression.hasCorrelatedSubquery(exists)) {
+ val (joinCond, outerPlan) = rewriteExistentialExpr(conditions, p)
+ buildJoin(outerPlan, sub, LeftAnti, joinCond)
+ } else {
+ Filter(Not(exists), newFilter)
+ }
Review comment:
@AngersZhuuuu I discussed this with Wenchen briefly. Do you think we can
safely inject a "LIMIT 1" into our subplan to expedite its execution ? Pl. lets
us know what you think ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
