Github user lianhuiwang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4141#discussion_r24241097
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnAllocator.scala ---
    @@ -124,10 +123,12 @@ private[yarn] class YarnAllocator(
         amClient.getMatchingRequests(RM_REQUEST_PRIORITY, location, 
resource).map(_.size).sum
     
       /**
    -   * Request as many executors from the ResourceManager as needed to reach 
the desired total.
    +   * Request as many executors from the ResourceManager as needed to reach 
the desired total. If
    +   * the requested total is smaller than the current number of running 
executors, no executors will
    +   * be killed.
    --- End diff --
    
    yes,amClient.removeContainerRequest is only to remove requests, not 
allocated containers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to