vanzin commented on a change in pull request #25299: [SPARK-27651][Core] Avoid the network when shuffle blocks are fetched from the same host URL: https://github.com/apache/spark/pull/25299#discussion_r346437749
########## File path: common/network-common/src/main/java/org/apache/spark/network/client/AsyncResponseCallback.java ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.network.client; + +/** + * Callback for the result of a single call. + * This will be invoked once with either success or failure. + */ +public interface AsyncResponseCallback<T> { Review comment: Ok I missed that it's used in `ExternalBlockStoreClient` which is not in core. Still, it doesn't look like it belongs in this module for the reason I explained - it's exposing functionality that is intentionally not provided by this module. Looking at it, it seems that `ExternalBlockStoreClient.getHostLocalDirs` could be implemented in `BlockManager`, thus avoiding this. It's just sending an RPC, so all you need are the request and response types defined in this library, and the code to actually call `sendRpc` could be in `BlockManager`. Then you could just use a `Promise`, which is both async (if needed) and typed, in the call sites. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
