cloud-fan commented on a change in pull request #26420: [SPARK-27986][SQL]
Support ANSI SQL filter predicate for aggregate expression.
URL: https://github.com/apache/spark/pull/26420#discussion_r347947991
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/unresolved.scala
##########
@@ -244,7 +244,8 @@ case class UnresolvedGenerator(name: FunctionIdentifier,
children: Seq[Expressio
case class UnresolvedFunction(
name: FunctionIdentifier,
children: Seq[Expression],
- isDistinct: Boolean)
+ isDistinct: Boolean,
+ filter: Option[Expression] = None)
Review comment:
shall we treat `filter` as child as well? e.g.
```
case class UnresolvedFunction(... inputs: Seq[Expression], ... filter:
Option[Expression] = None) {
def children = inputs ++ filter
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
