maropu commented on a change in pull request #26472: [SPARK-29838][SQL] PostgreSQL dialect: cast to timestamp URL: https://github.com/apache/spark/pull/26472#discussion_r348433032
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/PostgreSQLDialect.scala ########## @@ -46,4 +46,19 @@ object PostgreSQLDialect { } } } + + object CastToTimestamp extends Rule[LogicalPlan] { + override def apply(plan: LogicalPlan): LogicalPlan = { + val conf = SQLConf.get + if (conf.usePostgreSQLDialect) { Review comment: nit: I think we don't need to define a variable for `SQLConf`: `if (SQLConf.get.usePostgreSQLDialect) {` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org