maropu commented on a change in pull request #26615: [SPARK-29977][SQL] Remove newMutableProjection/newOrdering/newNaturalAscendingOrdering from SparkPlan URL: https://github.com/apache/spark/pull/26615#discussion_r348917261
########## File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/ordering.scala ########## @@ -19,18 +19,24 @@ package org.apache.spark.sql.catalyst.expressions import org.apache.spark.sql.catalyst.InternalRow import org.apache.spark.sql.catalyst.expressions.BindReferences.bindReferences +import org.apache.spark.sql.catalyst.expressions.codegen.GenerateOrdering import org.apache.spark.sql.types._ +/** + * A base class for generated/interpreted row ordering. + */ +abstract class BaseOrdering extends Ordering[InternalRow] Review comment: Honestly, not sure. It seems this base class has been implemented for making it easily accessible from generated code? https://github.com/apache/spark/blob/d555f8fcc964e6e81f2d849de62d06877dca70c5/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala#L158 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
