maryannxue commented on a change in pull request #26625: [SPARK-29893][SQL][followup] code cleanup for local shuffle reader URL: https://github.com/apache/spark/pull/26625#discussion_r349430708
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala ########## @@ -83,9 +83,8 @@ case class ShuffleExchangeExec( new ShuffledRowRDD(shuffleDependency, readMetrics, partitionStartIndices) } - def createLocalShuffleRDD( - advisoryParallelism: Option[Int] = None): LocalShuffledRowRDD = { - new LocalShuffledRowRDD(shuffleDependency, readMetrics, advisoryParallelism) + def createLocalShuffleRDD(partitionStartIndices: Array[Array[Int]]): LocalShuffledRowRDD = { Review comment: As long as we have a clear javadoc, I don't even think changing the name is necessary here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org