Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4168#discussion_r24366945
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
    @@ -201,18 +201,35 @@ private[spark] class ExecutorAllocationManager(
       }
     
       /**
    -   * If the add time has expired, request new executors and refresh the 
add time.
    -   * If the remove time for an existing executor has expired, kill the 
executor.
    +   * The number of executors we would have if the cluster manager were to 
fulfill all our requests.
    +   */
    +  private def targetNumExecutors(): Int =
    +    numExecutorsPending + executorIds.size
    --- End diff --
    
    I see, that's fine


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to