Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4168#discussion_r24381075
  
    --- Diff: 
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
    @@ -23,12 +23,19 @@ package org.apache.spark
     private[spark] trait ExecutorAllocationClient {
     
       /**
    -   * Request an additional number of executors from the cluster manager.
    -   * Return whether the request is acknowledged by the cluster manager.
    +   * Express a preference to the cluster manager for a given total number 
of executors. This can
    +   * result in canceling pending requests or filing additional requests.
        */
    -  def requestExecutors(numAdditionalExecutors: Int): Boolean
    +  def requestTotalExecutors(numExecutors: Int): Boolean
     
       /**
    +   * Request an additional number of executors from the cluster manager.
    +   * This is currently only supported in Yarn mode. Return whether the 
request is received.
    --- End diff --
    
    YARN?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to