cloud-fan commented on a change in pull request #26712: [SPARK-29883][SQL]
Improve error messages when function name is an alias
URL: https://github.com/apache/spark/pull/26712#discussion_r353109771
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala
##########
@@ -631,6 +631,24 @@ object FunctionRegistry {
(name, (expressionInfo[T](name), builder))
}
+ private def expressionWithAlias[T <: Expression](name: String)
+ (implicit tag: ClassTag[T]): (String, (ExpressionInfo, FunctionBuilder))
= {
+ val constructors = tag.runtimeClass.getConstructors
+ .filter(_.getParameterTypes.head == classOf[String])
+ assert(constructors.length == 1)
+ val builder = (expressions: Seq[Expression]) => {
+ Try(constructors.head.newInstance(name.toString,
expressions.head).asInstanceOf[Expression])
Review comment:
seems better to use the normal try catch?
```
try {
constructors.head.newInstance(name.toString,
expressions.head).asInstanceOf[Expression]
} catch {
// the original comment ...
case e => throw new AnalysisException(e.getCause.getMessage)
}
```
We can update `def expression` as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
