cloud-fan commented on a change in pull request #26412: [SPARK-29774][SQL] Date
and Timestamp type +/- null should be null as Postgres
URL: https://github.com/apache/spark/pull/26412#discussion_r353221092
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala
##########
@@ -68,10 +68,10 @@ package object dsl {
def unary_! : Predicate = Not(expr)
def unary_~ : Expression = BitwiseNot(expr)
- def + (other: Expression): Expression = Add(expr, other)
- def - (other: Expression): Expression = Subtract(expr, other)
- def * (other: Expression): Expression = Multiply(expr, other)
- def / (other: Expression): Expression = Divide(expr, other)
+ def + (other: Expression): Expression = UnresolvedAdd(expr, other)
Review comment:
do we have to change the DSL? mostly `+` means `Add`, we can write
`UnresolvedAdd` directly when necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
