aokolnychyi commented on a change in pull request #26751: [SPARK-30107][SQL]
Expose nested schema pruning to all V2 sources
URL: https://github.com/apache/spark/pull/26751#discussion_r353969026
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/FileScanBuilder.scala
##########
@@ -26,34 +26,40 @@ abstract class FileScanBuilder(
fileIndex: PartitioningAwareFileIndex,
dataSchema: StructType) extends ScanBuilder with
SupportsPushDownRequiredColumns {
private val partitionSchema = fileIndex.partitionSchema
+ private val partitionNameSet = toNameSet(partitionSchema)
private val isCaseSensitive =
sparkSession.sessionState.conf.caseSensitiveAnalysis
protected var requiredSchema = StructType(dataSchema.fields ++
partitionSchema.fields)
override def pruneColumns(requiredSchema: StructType): Unit = {
- this.requiredSchema = requiredSchema
+ // the default implementation prunes only top-level columns
+ // file formats that support nested column pruning must override this
+ val fields = dataSchema.fields ++ partitionSchema.fields
Review comment:
What about extending `FileBasedDataSourceSuite` to cover csv as well? It
seems there is a test for orc/parquet/json already.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
