srowen commented on a change in pull request #26757: [SPARK-30121][Build] Fix memory usage in sbt build script URL: https://github.com/apache/spark/pull/26757#discussion_r354258794
########## File path: build/sbt ########## @@ -66,7 +66,7 @@ Usage: $script_name [options] -sbt-dir <path> path to global settings/plugins directory (default: ~/.sbt) -sbt-boot <path> path to shared boot directory (default: ~/.sbt/boot in 0.11 series) -ivy <path> path to local Ivy repository (default: ~/.ivy2) - -mem <integer> set memory options (default: $sbt_mem, which is $(get_mem_opts $sbt_mem)) + -mem <integer> set memory options (default: $sbt_default_mem, which is $(get_mem_opts $sbt_default_mem)) Review comment: This doesn't update to 1.3.4 at all, no. (Moving to sbt 1.x is a fairly significant change; I couldn't get it to work a year ago) The script here is bits and pieces of an old sbt 0.x script. This is just fixing the mem message, and happens to mimic some lines from a newer sbt script. Incidentally, I kind of would like to remove the build/mvn and build/sbt scripts anyway. It works fine with recent mvn and I don't think build tools are hard to install for developers. Although installing sbt locally installs a new version, it still does understand the 0.13-based build. I don't know how much people are attached to this 'built in' wrapper, and I don't feel strongly about. Of course I'd also like to stop supporting 2 builds and would remove sbt. But that may wait until we face problems keeping the current one working with Scala 2.13.x or something. These are both quite separate issues. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
