dongjoon-hyun commented on a change in pull request #26769: [SPARK-30011][SQL]
Inline 2.12 "AsIfIntegral" classes, not present in 2.13
URL: https://github.com/apache/spark/pull/26769#discussion_r354586666
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/types/Decimal.scala
##########
@@ -622,6 +623,9 @@ object Decimal {
override def toLong(x: Decimal): Long = x.toLong
override def fromInt(x: Int): Decimal = new Decimal().set(x)
override def compare(x: Decimal, y: Decimal): Int = x.compare(y)
+ // Added from Scala 2.13; don't override to work in 2.12
+ // TODO revisit once Scala 2.12 support is dropped
Review comment:
Oh, what I meant is to have the official JIRA ID and make this
`TODO(SPARK-XXX)` style. It'll give more visibility to the community and
contributors can easily find both here and Apache Spark JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
