cloud-fan commented on a change in pull request #26741: [SPARK-30104][SQL] Fix 
catalog resolution for 'global_temp'
URL: https://github.com/apache/spark/pull/26741#discussion_r354673475
 
 

 ##########
 File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/LookupCatalog.scala
 ##########
 @@ -133,7 +133,11 @@ private[sql] trait LookupCatalog extends Logging {
         // For example, if the name of a custom catalog is the same with 
`GLOBAL_TEMP_DATABASE`,
         // this custom catalog can't be accessed.
         if (nameParts.head.equalsIgnoreCase(globalTempDB)) {
 
 Review comment:
   Let's just change `CatalogAndIdentifierParts` first. We can have a followup 
to clean up these patterns defined in `LookupCatalog.scala`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to