HeartSaVioR commented on a change in pull request #26788:
[WIP][SPARK-30159][SQL][TESTS] Fix the method calls of `QueryTest.checkAnswer`
URL: https://github.com/apache/spark/pull/26788#discussion_r355224671
##########
File path:
sql/core/src/test/java/test/org/apache/spark/sql/JavaSaveLoadSuite.java
##########
@@ -43,7 +43,7 @@
Dataset<Row> df;
private static void checkAnswer(Dataset<Row> actual, List<Row> expected) {
- String errorMessage = QueryTest$.MODULE$.checkAnswer(actual, expected);
+ String errorMessage =
QueryTest$.MODULE$.getErrorMessageInCheckAnswer(actual, expected);
if (errorMessage != null) {
Review comment:
If there's no issue on calling `fail` from scalatest in java suite (mixed-up
usage), that seems the way to go; otherwise we may be able to have another
QueryTest as utility class for java suite, and move this method instead and
co-use across java suites.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
