Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/3425#issuecomment-73737787
What was the outcome here? I can't claim to be an expert, but, obviously
`localhost` is a symbolic name and that's generally the right thing to use to
mean "the local machine", whereas `127.0.0.1` always means an IPv4 endpoint
reached by TCP. The potential extra name resolution time isn't an issue here.
When would `localhost` not resolve?
FWIW the SocketServer example in Python docs uses `localhost`
(https://docs.python.org/2/library/socketserver.html). Most of Spark does too,
but, I see an example in the Python code in `daemon.py` where a process listens
on `127.0.0.1`.
Leave it unless there is a problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
