HeartSaVioR commented on a change in pull request #26416: [SPARK-29779][CORE] Compact old event log files and cleanup URL: https://github.com/apache/spark/pull/26416#discussion_r355823417
########## File path: docs/configuration.md ########## @@ -1023,6 +1023,24 @@ Apart from these, the following properties are also available, and may be useful The max size of event log file before it's rolled over. </td> </tr> +<tr> + <td><code>spark.eventLog.rolling.maxFilesToRetain</code></td> + <td>Int.MaxValue</td> + <td> + The maximum number of event log files which will be retained as non-compacted. + By default, all event log files will be retained. Please set the configuration and + <code>spark.eventLog.rolling.maxFileSize</code> accordingly if you want to control + the overall size of event log files. The event log files older than these retained + files will be compacted into single file and deleted afterwards.<br/> + NOTE 1: Compaction will happen in Spark History Server, which means the same value + will be applied across applications which are being loaded in Spark History Server, + as well as compaction and cleanup would require running Spark History Server.<br/> + NOTE 2: Spark History Server may not compact the old event log files if it figures + out compaction on event log for such application won't reduce the size at expected Review comment: Ah yes, we don't expose the rate threshold hence it's odd to explicitly say it. Good point. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org