cloud-fan commented on a change in pull request #26741: [SPARK-30104][SQL] Fix
catalog resolution for 'global_temp'
URL: https://github.com/apache/spark/pull/26741#discussion_r355883930
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/catalog/LookupCatalog.scala
##########
@@ -92,15 +92,50 @@ private[sql] trait LookupCatalog extends Logging {
* Catalog name takes precedence over namespaces.
*/
object CatalogAndNamespace {
- def unapply(parts: Seq[String]): Some[(CatalogPlugin,
Option[Seq[String]])] = parts match {
- case Seq(catalogName, tail @ _*) =>
+ def unapply(nameParts: Seq[String]): Some[(CatalogPlugin, Seq[String])] = {
+ assert(nameParts.nonEmpty)
+ nameParts match {
Review comment:
hmm, is it fixed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
