dongjoon-hyun commented on a change in pull request #26779: [SPARK-30150][SQL]
ADD FILE, ADD JAR, LIST FILE & LIST JAR Command do not accept quoted path
URL: https://github.com/apache/spark/pull/26779#discussion_r356402934
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/SparkSqlParserSuite.scala
##########
@@ -259,4 +259,22 @@ class SparkSqlParserSuite extends AnalysisTest {
parser.parsePlan("ALTER SCHEMA foo SET DBPROPERTIES ('x' = 'y')"))
assertEqual("DESC DATABASE foo", parser.parsePlan("DESC SCHEMA foo"))
}
+
+ test("manage resources") {
+ assertEqual("ADD FILE abc.txt", AddFileCommand("abc.txt"))
+ assertEqual("ADD FILE \'abc.txt\'", AddFileCommand("abc.txt"))
+ assertEqual("ADD FILE \"/path/to/abc.txt\"",
AddFileCommand("/path/to/abc.txt"))
+ assertEqual("LIST FILE abc.txt", ListFilesCommand("abc.txt".split("\\s+")))
+ assertEqual("LIST FILE \'/path//abc.txt\'",
ListFilesCommand("/path//abc.txt".split("\\s+")))
+ assertEqual("LIST FILE \"/path2/abc.txt\"",
ListFilesCommand("/path2/abc.txt".split("\\s+")))
+ assertEqual("ADD JAR /path2/_2/abc.jar",
AddJarCommand("/path2/_2/abc.jar"))
+ assertEqual("ADD JAR \'/test/path_2/jar/abc.jar\'",
AddJarCommand("/test/path_2/jar/abc.jar"))
+ assertEqual("ADD JAR \"abc.jar\"", AddJarCommand("abc.jar"))
+ assertEqual("LIST JAR /path-with-dash/abc.jar",
+ ListJarsCommand("/path-with-dash/abc.jar".split("\\s+")))
+ assertEqual("LIST JAR \'abc.jar\'",
ListJarsCommand("abc.jar".split("\\s+")))
+ assertEqual("LIST JAR \"abc.jar\"",
ListJarsCommand("abc.jar".split("\\s+")))
+ assertEqual("ADD FILE /path with space/abc.txt", AddFileCommand("/path
with space/abc.txt"))
+ assertEqual("ADD JAR /path with space/abc.jar", AddJarCommand("/path with
space/abc.jar"))
Review comment:
Although our parser will accept without any differences, shall we have a
test case for Window-path, too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
