cloud-fan commented on a change in pull request #26773: [SPARK-30126][CORE] sparkContext.addFile and sparkContext.addJar fails when file path contains spaces URL: https://github.com/apache/spark/pull/26773#discussion_r356439923
########## File path: core/src/test/scala/org/apache/spark/SparkContextSuite.scala ########## @@ -233,6 +233,42 @@ class SparkContextSuite extends SparkFunSuite with LocalSparkContext with Eventu } } + test("SPARK-30126: addFile when file path contains spaces with recursive works") { + withTempDir { dir => + try { + val sep = File.separator + val tmpDir = Utils.createTempDir(dir.getAbsolutePath + sep + "test space") + val tmpConfFile1 = File.createTempFile("test", ".conf", tmpDir) Review comment: can we also add space in the file name to prove it works? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org