Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/4514#issuecomment-73824804
This is a very bold change. :)
* 10K feet comment - Isnt ManualClock more descriptive name than FakeClock?
* For other clocks, like the Clock in streaming, since those were
replacable using SparkConf, might be worth adding backward compatible way to
instantiate clock. Example, even setting `streaming.clock` to
`streaming.ManualClock` will isntantiate the correct clock.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
