cloud-fan commented on a change in pull request #26906:
[SPARK-30066][SQL][FOLLOWUP] Remove size field for interval column cache
URL: https://github.com/apache/spark/pull/26906#discussion_r358231026
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/ColumnType.scala
##########
@@ -705,14 +705,11 @@ private[columnar] case class MAP(dataType: MapType)
override def clone(v: UnsafeMapData): UnsafeMapData = v.copy()
}
-private[columnar] object CALENDAR_INTERVAL extends ColumnType[CalendarInterval]
- with DirectCopyColumnType[CalendarInterval] {
+private[columnar] object CALENDAR_INTERVAL extends
ColumnType[CalendarInterval] {
override def dataType: DataType = CalendarIntervalType
- override def defaultSize: Int = 16
-
- override def actualSize(row: InternalRow, ordinal: Int): Int = 20
+ override val defaultSize: Int = 16
Review comment:
is it better to use `def`? to follow `def dataType`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
