vanzin commented on a change in pull request #26845: [SPARK-21869][SS] Revise Kafka producer pool to implement 'expire' correctly URL: https://github.com/apache/spark/pull/26845#discussion_r358414499
########## File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/producer/InternalKafkaProducerPoolSuite.scala ########## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.kafka010.producer + +import java.{util => ju} +import java.util.concurrent.{Executors, TimeUnit} + +import scala.util.Random + +import org.apache.kafka.common.serialization.ByteArraySerializer +import org.jmock.lib.concurrent.DeterministicScheduler + +import org.apache.spark.SparkConf +import org.apache.spark.sql.kafka010.{PRODUCER_CACHE_EVICTOR_THREAD_RUN_INTERVAL, PRODUCER_CACHE_TIMEOUT} +import org.apache.spark.sql.kafka010.producer.InternalKafkaProducerPool.CachedProducerEntry +import org.apache.spark.sql.test.SharedSparkSession +import org.apache.spark.util.ManualClock + +class InternalKafkaProducerPoolSuite extends SharedSparkSession { + + private var pool: InternalKafkaProducerPool = _ + + protected override def afterEach(): Unit = { + if (pool != null) { + try { + pool.shutdown() + pool = null + } catch { + // ignore as it's known issue, DeterministicScheduler doesn't support shutdown + case _: UnsupportedOperationException => + } + } + } + + test("Should return same cached instance on calling acquire with same params.") { + pool = new InternalKafkaProducerPool(new SparkConf()) + + val kafkaParams = getTestKafkaParams() + val producer = pool.acquire(kafkaParams) + val producer2 = pool.acquire(kafkaParams) + assert(producer === producer2) Review comment: You want them to be the same instance, right? So probably `eq` is more correct than `===`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
